Editing Module talk:Hatnote (section)

== Spacey space ==

{{edit template-protected|answered=yes}}
The module's <code>_formatLink</code> function adds an unnecessary space when fed just a section. E.g.:

{| class="wikitable"
!Input
|{{Code|<nowiki>({{format linkr|#Italicize}})</nowiki>}}
|-
!Output (expected)
|([[:#Italicize|§&nbsp;Italicize]])
|-
!Output (actual)
|([[:#Italicize| §&nbsp;Italicize]])
|}

Therefore please copy the sandbox to the main module. I checked that it was synced first. Test cases were also added; those who for some strange reason want the old behavior back can specify {{para|italicizePage|true}}, which will do it as a side effect of adding an empty {{tag|i}}. [[User:Psiĥedelisto|Psiĥedelisto]] ([[User talk:Psiĥedelisto|talk]] • [[Special:Contributions/Psiĥedelisto|contribs]]) <sup>please ''always'' [[Help:Notifications|ping]]!</sup> 23:36, 28 July 2020 (UTC)
: {{ping|Psiĥedelisto}} {{done}} [[User:Pppery|* Pppery *]] [[User talk:Pppery|<sub style="color:#800000">it has begun...</sub>]] 00:47, 29 July 2020 (UTC)
:: {{ping|Psiĥedelisto}} Thanks for spotting this and for making the fix. Having section-only links that add an empty {{tag|i}} also sounds like a bug to me, so I [[Special:Diff/970053730/970133728|added another test case]] and made a [[Special:Diff/970133456|fix in the sandbox]]. Do you think this would be a good addition to the module? Best — '''''[[User:Mr. Stradivarius|<span style="color: #194D00; font-family: Palatino, Times, serif">Mr.&nbsp;Stradivarius</span>]]''''' <sup>[[User talk:Mr. Stradivarius|♪&nbsp;talk&nbsp;♪]]</sup> 13:29, 29 July 2020 (UTC)
:::{{re|Mr. Stradivarius}} I certainly do, I only didn't fix it myself so that there would be a way to get the old behavior back, no matter how broken; some TP ER implementers care about that sort of thing quite a lot, and I never know who I'm gonna end up with when I make my requests. {{=3|8}} [[User:Psiĥedelisto|Psiĥedelisto]] ([[User talk:Psiĥedelisto|talk]] • [[Special:Contributions/Psiĥedelisto|contribs]]) <sup>please ''always'' [[Help:Notifications|ping]]!</sup> 16:14, 29 July 2020 (UTC)
::::{{re|Psiĥedelisto}} It looks like the extra initial space for section-only links has been in the template for a long time, so I suppose it's possible that some people might have come to rely on that behaviour. This seems unexpected enough to me, though, that such people are probably in a small minority, if indeed they exist. I say we go ahead and fix it, and then see if anyone complains. We can work out any next steps to take after that. Best — '''''[[User:Mr. Stradivarius|<span style="color: #194D00; font-family: Palatino, Times, serif">Mr.&nbsp;Stradivarius</span>]]''''' <sup>[[User talk:Mr. Stradivarius|♪&nbsp;talk&nbsp;♪]]</sup> 13:43, 30 July 2020 (UTC)
:::::I've gone ahead and put my fix up live. — '''''[[User:Mr. Stradivarius|<span style="color: #194D00; font-family: Palatino, Times, serif">Mr.&nbsp;Stradivarius</span>]]''''' <sup>[[User talk:Mr. Stradivarius|♪&nbsp;talk&nbsp;♪]]</sup> 13:48, 30 July 2020 (UTC)