Editing Module talk:Sidebar (section)

== Removing sidebar images as page image ==

(continuation of [[Module_talk:Sidebar/Archive_6#Removing_sidebar_images_as_page_image|Module talk:Sidebar/Archive 6#Removing sidebar images as page image]])

@[[User:Izno|Izno]]: I've added <code>notpageimage</code> to the [[Template:Sidebar/sandbox|sandbox]] and [[Module:Sidebar/configuration/sandbox|its configuration]]. [[User:The RedBurn|The RedBurn]] <small>([[User Talk:The RedBurn|ϕ]])</small> 06:36, 30 August 2025 (UTC)

:@[[User:The RedBurn|The RedBurn]] Unfortunately, the class needs to be on the <code>[[File:</code> syntax and not on a container of that item.
:(NB make sure the ping is attempted in the same edit as you sign.) [[User:Izno|Izno]] ([[User talk:Izno|talk]]) 16:53, 1 September 2025 (UTC)
::@[[User:Izno|Izno]]: I've updated the [[Module:Sidebar/sandbox|sandbox]] to add the class to the <code>[[File:</code> part. [[User:The RedBurn|The RedBurn]] <small>([[User Talk:The RedBurn|ϕ]])</small> 14:54, 2 September 2025 (UTC)
:::Good start. In the else case, what about when there is arbitrary HTML in the parameter? [[User:Izno|Izno]] ([[User talk:Izno|talk]]) 15:55, 2 September 2025 (UTC)
:::Or a link (or links) in the if branch. [[User:Izno|Izno]] ([[User talk:Izno|talk]]) 15:56, 2 September 2025 (UTC)
::::Per [[Template:Sidebar#Parameters]] it's supposed to be full wiki syntax (<code>[[File:</code>).
::::I'm not sure what you mean by "a link (or links) in the if branch". [[User:The RedBurn|The RedBurn]] <small>([[User Talk:The RedBurn|ϕ]])</small> 18:17, 2 September 2025 (UTC)
:::::{{tq|it's supposed to be full wiki syntax}} Assuming without evidence that people follow the documentation or any expectations at all is a bad idea. :) That's how we got a failed "divification" of this template (and I'm sure many other failed rollouts of other software over the years).
:::::{{tq|a link (or links) in the if branch}} I realize I read this wrong in hindsight, but I think it rolls back around to the first comment about assuming the documentation is king.
:::::We need/want to substantiate your claim that the documentation reflects reality about the use of the image arguments {{em|or}} make something a bit more resilient to all the fun things users do. [[User:Izno|Izno]] ([[User talk:Izno|talk]]) 18:57, 2 September 2025 (UTC)
::::::I've just checked it out on [[Template:Greek mythology sidebar]].
::::::With <code><nowiki>[[Greek mythology|class=notopimage]]</nowiki></code> the "image" is shown as [[Greek mythology|class=notopimage]] instead of [[Greek mythology]].
::::::With <code><nowiki><img src="Kylix Theseus Aison MNA Inv11365 n1.jpg">class=notopimage]]</nowiki></code> it shows up as <img src="Kylix Theseus Aison MNA Inv11365 n1.jpg">class=notopimage]] which isn't much worse than without the "class=notopimage]]" bit. I seriously doubt that's actually used for that parameter.
::::::I don't see the point in making the code more complex for these two cases. [[User:The RedBurn|The RedBurn]] <small>([[User Talk:The RedBurn|ϕ]])</small> 21:22, 2 September 2025 (UTC)
:::::::Why would we expect raw image HTML, which is distinctly {{em|not}} a possibility in this environment?
:::::::I'm talking the basic <code>&lt;div class=""></code> or <code><nowiki>{| class=""</nowiki></code>, either of which one might find in this element (possibly by transcluded content - as a particular example, {{tl|Politics sidebar title}}, which is supposed to be put in {{para|title}} but that doesn't stop people).
:::::::And I think the former case is precisely something to concern oneself with. Users on this wiki if nowhere else don't like anything breaking, whether or not their understanding is calibrated correctly.
:::::::NB I am not trying to make your life difficult. I am pointing out that the masses will come for anyone who didn't consider factors like the above and account for them directly in what is deployed. [[User:Izno|Izno]] ([[User talk:Izno|talk]]) 21:47, 2 September 2025 (UTC)
::::::::That specific example <nowiki>{{</nowiki>[[Template:Politics sidebar title|Politics sidebar title]]<nowiki>}}</nowiki> wouldn't matter because it doesn't use the image arg, but I get your point.
::::::::I've added a sanity check for <code>[[File:</code> or <code>[[Image:</code>.
::::::::Incidentally, I've fixed it to use the correct <code>notpageimage</code> class. [[User:The RedBurn|The RedBurn]] <small>([[User Talk:The RedBurn|ϕ]])</small> 06:36, 3 September 2025 (UTC)
:::::::::{{replyto|The RedBurn}} Please see [[Module talk:Sidebar#c-Redrose64-20250510125700-Noleander-20250510013900|my post of 12:57, 10 May 2025 (UTC)]] for the method of adding a class to an image. --[[User:Redrose64|<span style="color:#a80000; background:#ffeeee; text-decoration:inherit">Red</span>rose64]] &#x1f339; ([[User talk:Redrose64|talk]]) 19:33, 3 September 2025 (UTC)
::::::::::The modification proposed for the module is intended to add that class automatically to the templates that use this module. [[User:The RedBurn|The RedBurn]] <small>([[User Talk:The RedBurn|ϕ]])</small> 20:35, 3 September 2025 (UTC)