Editing Module talk:Sidebar (section)

== ARIA ==

{{edit template-protected|answered=yes}}
Hi, per WIA-ARIA, can the parent {{tag|table|o}} HTML element with classes <code>sidebar sidebar-collapse nomobile nowraplinks</code> please get an ARIA role. Like the Mbox templates (see [[Module:Message box]], I was thinking <code>role="none"</code> is most appropriate. Although, in this case since most sidebars are navigation boxes it may be helpful to able to pass a boolean parameter to change the ARIA role given to <code>role="navigation"</code>. 

@[[User:Izno|Izno]] What do you think? Sorry, I'm browsing around with my screenreader and noticed the sidebar also uses HTML tables still... Are you also on-board with <code>role="none"</code> and a boolean argument to switch this to <code>role="navigation"</code>?

(P.S. future me or someone else kind enough I can proof it—will have to also explain clearly and succinctly in sidebar and sidebar with collapsible lists template docs how to use lists (that expose {{tag|ul|o}}, {{tag|li|o}}, etc.) and be ARIA-friendly i.e. grouping them so they're read out usefully, labelling (!!) so important as otherwise a long babelling electronic voice of hyperlinks is all the visually impaired has for reference etc. if this is even possible to achieve on WP...) <span style="color:#CD0000">[[User:Waddie96|waddie96]] ★ ([[User talk:Waddie96|talk]])</span> 02:47, 1 September 2025 (UTC)

:Sidebars are either nav or aside, if we were to use HTML elements that I don't current have access to. I'll mark it up as nav for now in the sandbox. [[User:Izno|Izno]] ([[User talk:Izno|talk]]) 16:57, 1 September 2025 (UTC)
::Thanks. I'm pretty confident that this particular WIA-ARIA work such as assigning roles to HTML elements whose semantics are incongruent to their use-case is an uncontroversial edit despite it being such a high-use page. Placing edit request.
::Kindly at the HTML attribute <code>role="navigation"</code> to the parent {{tag|table|o}} element please. This will replace the implicit semantics of a data table with the explicit semantics of a navigation group/group of links (the identical semantics as {{tag|nav|o}}) to accessibility technology. 
::I guessed this, so please don't slate me:
{{textdiff|<nowiki>:css('width', args.width or nil)
:cssText(args.bodystyle or args.style)</nowiki>
|<nowiki>:css('width', args.width or nil)
:cssText(args.bodystyle or args.style)
:attr("role", "navigation")</nowiki>}}
::or is it <code>setAttribute("role", "navigation")</code>? I feel like the former.<span style="color:#CD0000">[[User:Waddie96|waddie96]] ★ ([[User talk:Waddie96|talk]])</span> 17:39, 1 September 2025 (UTC)
:::Or you can just say sync to the sandbox. [[User:Izno|Izno]] ([[User talk:Izno|talk]]) 19:13, 1 September 2025 (UTC)
:{{not done for now}}''':'''<!-- Template:ETp --> Going to wait until RedBurn finishes their work. [[User:Izno|Izno]] ([[User talk:Izno|talk]]) 15:56, 2 September 2025 (UTC)
::Good day @[[User:Izno|Izno]]. Please can you just insert the code I posted below for now. There's no timeline how long it may take the sandbox editing/testing to finish, and this edit won't need much testing beyond me checking ten or so use-cases that it actually shows up... At line 156, insert the highlighted code: <syntaxhighlight lang=lua line start="144" highlight="13" style="width:100%;font-size:small;">
	root = root:tag('table')
	if not child then
		root 
			:addClass(cfg.i18n.class.sidebar)
			-- force collapsibleclass to be sidebar-collapse otherwise output nothing
			:addClass(collapsibleClass == cfg.i18n.class.collapse and cfg.i18n.class.collapse or nil)
			:addClass('nomobile')
			:addClass(args.float == cfg.i18n.float_none and cfg.i18n.class.float_none or nil)
			:addClass(args.float == cfg.i18n.float_left and cfg.i18n.class.float_left or nil)
			:addClass(args.wraplinks ~= cfg.i18n.wrap_true and cfg.i18n.class.wraplinks or nil)
			:addClass(args.bodyclass or args.class)
			:css('width', args.width or nil)
			:attr('role', 'presentation')
			:cssText(args.bodystyle or args.style)
</syntaxhighlight> Thank you <span class="fn nickname" style="color:#CD0000">[[User:Waddie96|waddie96]] ★ ([[User talk:Waddie96|talk]])</span> 16:19, 7 September 2025 (UTC)
:::The reason I have not done so is because we expect to have two changes and I'm preventing the [[WP:Job queue]] from having to swallow two in some relatively quick procession (editing highly used modules has been observed by the WMF before). Users have lived with the change for many many years and is relatively minor at the end of the day. There is also 0 reason to test it any further. You should move on to more productive activities.  And lastly, setting role to presentation is already what we're not doing. [[User:Izno|Izno]] ([[User talk:Izno|talk]]) 16:29, 7 September 2025 (UTC)
::::Ah ok got you. Thanks for the education 😄. Observed meaning it was able to cause enough performance issues that WMF was able to track the cause all the way down to a module? Insane.
::::{{tq| You should move on to more productive activities.}} Please watch your tone though. <span class="fn nickname" style="color:#CD0000">[[User:Waddie96|waddie96]] ★ ([[User talk:Waddie96|talk]])</span> 20:19, 7 September 2025 (UTC)
::::If it’s in retaliation because I came across with tone I do apologise, the web doesn’t come with emotion semantics unless you use an emoticon 😅 <span class="fn nickname" style="color:#CD0000">[[User:Waddie96|waddie96]] ★ ([[User talk:Waddie96|talk]])</span> 20:21, 7 September 2025 (UTC)

{{edit request}}

Please adjust line-height to be in keeping with the increase at {{tl|infobox}}.
<syntaxhighlight lang=css>
.sidebar {
    line-height: 1.5em;
}
</syntaxhighlight> <span class="fn nickname" style="color:#CD0000">[[User:Waddie96|waddie96]] ★ ([[User talk:Waddie96|talk]])</span> 04:49, 14 September 2025 (UTC)

:Reason being: Currently, links etc. will be too bunched together, and it actually makes it 'harder' to read from an usability perspective since it appears busy/cluttered and 'a lot'. <span class="fn nickname" style="color:#CD0000">[[User:Waddie96|waddie96]] ★ ([[User talk:Waddie96|talk]])</span> 04:49, 14 September 2025 (UTC)