CosmicAvelyn: 1 revision imported

2025-09-14T05:11:56Z

1 revision imported

← Older revision	Revision as of 01:11, 14 September 2025
(No difference)

Wikipedia>Waddie96: /* Change background color for .fmbox-warning */ Reply

2025-09-11T18:07:21Z

Change background color for .fmbox-warning: Reply

New page

{{oldtfdfull|date= 2020 February 15 |result=keep |disc=Module:Message box}}
<noinclude>{{permprot}}</noinclude>
{{Archives|bot=lowercase sigmabot III|age=30}}
{{User:MiszaBot/config
| algo = old(30d)
| archive = Module talk:Message box/Archive %(counter)d
| counter = 1
| maxarchivesize = 150K
| archiveheader = {{Automatic archive navigator}}
| minthreadstoarchive = 1
| minthreadsleft = 4
}}

== Update icons to Codex ==

{{edit protected|ans=y}}
For [[Module:Message box/configuration]]
Update icons to use the new [https://doc.wikimedia.org/codex/latest/icons/overview.html Codex icons], I've colored them manually in [[:c:Category:Wikimedia Codex icons with color]], using the colors we used with near identical OOUI icons.
<gallery packed>
Codex icon Clear red.svg | ambox.speedy
Codex icon Alert red.svg | ambox.delete
Codex icon Notice orange.svg | ambox.warning ambox.content
Codex icon InfoFilled blue.svg | ambox.notice
Codex icon Notice blue.svg |'' or this for'' ambox.notice
OOjs UI icon broom.svg | ambox.style ''Not Codex, but OOUI for style icon...''
</gallery>
etc. In some cases cmbox will use different icon. [[User:Waddie96|waddie96]] ★ ([[User talk:Waddie96|talk]]) 12:06, 10 August 2025 (UTC)

:'''NOTE''': The current icons are licensed such that they do not need the link to work so that arribution works. These new icons are CC4 licensed, so attribution would be needed and the link= attribute would also need removing from the code if these are to be used. -- [[User:WOSlinker|WOSlinker]] ([[User talk:WOSlinker|talk]]) 12:23, 10 August 2025 (UTC)
::@[[User:WOSlinker|WOSlinker]] Sorry, I didn't do the mass upload to [[:c:Category:Wikimedia Codex icons with color]], I requested it at [[Commons:Batch uploading/Wikimedia Codex icons]], and I requested it be made with the appropriate license which is {{tl|MIT License}} found in the [[gerrit:plugins/gitiles/design/codex/+/refs/heads/main/packages/codex-icons/LICENSE]]. Also in the <code>package.json</code> it says <syntaxhighlight lang=json inline>"license": "MIT"</syntaxhighlight>.
::Also some the icons have already been there for a few years, and marked with {{tl|CC-by-4.0}}, mistakenly too I assume. Anyway, I marked my colourings of the icons with that too since it was a derivation.
::Anyway, CC-by-4.0 is incorrect license. {{tl|MIT License}} is the correct one. I will re-tag the ones at [[:c:Category:Wikimedia Codex icons with color]] and all the ones at [[:c:Category:Wikimedia Codex icons]] but the second one may take quite a while. [[User:Waddie96|waddie96]] ★ ([[User talk:Waddie96|talk]]) 13:08, 10 August 2025 (UTC)
:::[[MOS:PDI]] says that a blank {{para|link}} param - which is what we essentially do with mboxes - should not be used with CC BY-SA, GFDL, or similarly licensed images. I think that I'm right in saying that [[c:Template:MIT License]] falls within "similarly licensed images". --[[User:Redrose64|Redrose64]] 🌹 ([[User talk:Redrose64|talk]]) 13:24, 10 August 2025 (UTC)
::::@[[User:Redrose64|Redrose64]] But the same icons are implemented in the [[Wmdoc:codex/latest/components/demos/message.html|cdxMessage]] component in [[Wmdoc:Codex/latest|Codex]], and this component is deployed on this very wiki. This component shows the ''exact'' same images (just not using our source which is Commons) from the same Gerrit repo to display or messages we see all over. The entire package/library has the GNU General Public License see [[gerrit:plugins/gitiles/design/codex/+/refs/heads/main/packages/codex/LICENSE]]. [[User:Waddie96|waddie96]] ★ ([[User talk:Waddie96|talk]]) 13:49, 10 August 2025 (UTC)
:::::See [[Special:Version]]: codex-design-tokens GPL-2.0+, codex-icons MIT, codex GPL-2.0+, wikimedia/codex GPL-2.0-or-later [[User:Waddie96|waddie96]] ★ ([[User talk:Waddie96|talk]]) 13:50, 10 August 2025 (UTC)
::::::@[[User:Redrose64|Redrose64]] Also, is the use of the predecessor OOUI icons with MIT license in violation of copyright at [[mw:Module:Message box/configuration]] for example. [[User:Waddie96|waddie96]] ★ ([[User talk:Waddie96|talk]]) 14:29, 10 August 2025 (UTC)
:::::::Do we have consensus for these, has this change been discussed outside of this request ? [[User:Sohom Datta|Sohom]] ([[User talk:Sohom Datta|talk]]) 15:47, 10 August 2025 (UTC)
::::@[[User:Redrose64|Redrose64]] Where in the quoted policy does [[WP:PDI]] state {{tq|1=a blank <code>{{!}}link=</code> param - which is what we essentially do with mboxes - should not be used with CC BY-SA, GFDL, or similarly licensed images.}}? I couldn't find it. [[User:Waddie96|waddie96]] ★ ([[User talk:Waddie96|talk]]) 16:25, 10 August 2025 (UTC)
:::::Sorry, [[MOS:PDI]]. It's always confusing when otherwise-similar MOS: and WP: shortcuts take you to different places. --[[User:Redrose64|Redrose64]] 🌹 ([[User talk:Redrose64|talk]]) 16:28, 10 August 2025 (UTC)
::::::{{moved discussion|[[Wikipedia:Village pump (proposals)#c-Waddie96-20250810163900-Proposal to update messagebox module with new Codex icons]]}} [[User:Waddie96|waddie96]] ★ ([[User talk:Waddie96|talk]]) 16:39, 10 August 2025 (UTC)
:::::::I've answered the edit request as [[File:X mark.svg|20px|link=|alt=]] '''Not done for now:''' please establish a [[Wikipedia:Consensus|consensus]] for this alteration '''[[Wikipedia:Edit requests#Planning a request|before]]''' using the {{Tlx|Edit protected}} template. ([[Wikipedia:Non-admin closure|non-admin closure]]) [[User:Aaron Liu|Aaron Liu]] ([[User talk:Aaron Liu#top|talk]]) 02:21, 11 August 2025 (UTC)
==CSS instead of tables==
{{moved discussion from|Template talk:Ambox#CSS instead of tables|[[User:Sapphaline|Sapphaline]] ([[User talk:Sapphaline|talk]]) 10:25, 20 August 2025 (UTC)}}
Could this thing use <code><nowiki><div style="display:table;"></nowiki></code> and <code><nowiki><div style="display:table-cell;"></nowiki></code> instead of literal tables and table cells (<code><nowiki><table></nowiki></code>, <code><nowiki><td></nowiki></code>)?

Were the any previous attempts to remake this using <code><nowiki><div></nowiki></code>? If so, what was the consensus? [[User:Sapphaline|Sapphaline]] ([[User talk:Sapphaline|talk]]) 09:46, 20 August 2025 (UTC)

:A long time ago this would have been converted to divs but apparently IE sucked (this should not be news).
:Today, I have [[User:Izno/Sandbox/Ambox]] with what are some skimmings and started a sandbox at [[Module:Message box/div]]. I have just done a very bad job of finishing this work. [[User:Izno|Izno]] ([[User talk:Izno|talk]]) 22:09, 24 August 2025 (UTC)
::Which might be closer to done than not, honestly. I think what it currently needs is to
::# Double check the ambox work
::# Add "soft" support for the other kinds of boxes (where soft is defined as module-supports but config disabled)
::# Merge tested /div version but not CSS into main
::# Enable boxes of each kind one by one.
::#* Leave ambox for penultimate as the most likely to cause some mass noise in a way
::#* Probably somewhere around here do ombox, [https://en.wikipedia.org/w/index.php?search=insource%3A%2FMessage%5B%20_%5Dbox%5C%2Fombox%5C.css%2F%20-intitle%3A%2F(%5BSs%5Dandbox%7C%5C%2Fdoc)%2F&title=Special%3ASearch&profile=advanced&fulltext=1&ns10=1&ns828=1 that has some needed coordination]
::#* Leave tmbox for ultimate, there is work to [https://en.wikipedia.org/w/index.php?search=insource%3A%2FMessage%5B%20_%5Dbox%5C%2Ftmbox%5C.css%2F%20-intitle%3A%2F(%5BSs%5Dandbox%7C%5C%2Fdoc)%2F&title=Special%3ASearch&profile=advanced&fulltext=1&ns10=1&ns828=1 coordinate]
::# Fix bugs that are identified
::# Move CSS over to better-named stylesheet
::# Delete the /div CSS (I won't be too sad)
::# Remove main support for table versions, possibly rename some things
::[[User:Izno|Izno]] ([[User talk:Izno|talk]]) 22:42, 24 August 2025 (UTC)
::I have now put this plan in a publicly editable place at [[Module:Message box/div/doc]]. [[User:Izno|Izno]][[User:IznoPublic|Public]] ([[User talk:Izno#top|talk]]) 00:26, 26 August 2025 (UTC)
::Hi! I didn't know you were doing this, so I made something similar. It seems to work:
::* Module: [https://en.wikipedia.org/w/index.php?title=Module%3AMessage_box%2Fsandbox&diff=1310791170&oldid=1300331049]
::* Styles: [https://en.wikipedia.org/w/index.php?title=Module%3AMessage_box%2Fsandbox%2Fambox.css&diff=1310791252&oldid=1305438959]
:: [[User:Iniquity|Iniquity]] ([[User talk:Iniquity|talk]]) 16:57, 11 September 2025 (UTC)
:::Yes, I did it in its own sandbox because it's a longterm enough project not to be done in the main sandbox, which should generally be releasable ad hoc for trivial issues. [[User:Izno|Izno]] ([[User talk:Izno|talk]]) 17:03, 11 September 2025 (UTC)
:::And also, there are enough other dependencies that "just change the two or three places" isn't going to fly. [[User:Izno|Izno]] ([[User talk:Izno|talk]]) 17:06, 11 September 2025 (UTC)
::::Where else do you think this will affect? It seems that only the mobile version is oriented towards <syntaxhighlight inline lang="css">table.ambox</syntaxhighlight>, which can also be corrected by CSS [[User:Iniquity|Iniquity]] ([[User talk:Iniquity|talk]]) 17:09, 11 September 2025 (UTC)
:::::I have already documented in [[Module:Message box/div/doc]] multiple places that will need careful work, ambox among them. Please feel free to peruse and ask questions about what's there and why. [[User:Izno|Izno]] ([[User talk:Izno|talk]]) 17:41, 11 September 2025 (UTC)
::::::Thanks! [[User:Iniquity|Iniquity]] ([[User talk:Iniquity|talk]]) 17:47, 11 September 2025 (UTC)
:What's broken here? I've probably wrong but AFAIK for accessibility the existing role="presentation" should suffice. [[User:Aaron Liu|Aaron Liu]] ([[User talk:Aaron Liu#top|talk]]) 23:21, 28 August 2025 (UTC)
::You should always endeavor to use the default aria role element. In this case, that's not a table. Ignoring that, tables are shit for doing other presentation with. [[User:Izno|Izno]] ([[User talk:Izno|talk]]) 03:20, 29 August 2025 (UTC)
:::This /div work is great work, thanks for this [[User:Waddie96|waddie96]] ★ ([[User talk:Waddie96|talk]]) 19:49, 8 September 2025 (UTC)

== Aria roles ==
{{archive top|status=SUMMARISED BELOW|outcome=[[User:Waddie96|waddie96]] ★ ([[User talk:Waddie96|talk]]) 19:14, 2 September 2025 (UTC)}}

The elements with <code>role=none</code> (synonym for <code>presentation</code> which is not recommended for use) is not be hidden from the accessibility API ''but'' their ''implicit'' semantics are hidden. Meaning the contents of an Ambox for instance will not have the implicit semantics of a HTML data <code><table<nowiki/>></code>. So the content given in {{para|text}} will simply be presented to the accessibility API technology as {{tag|div|content=Content}} instead of {{tag|table|content=Content}} which is what we want, yes. However, the accessibility technology, i.e. screen reader, etc., will not have any idea what this text is or what it represents since the {{tag|div|o}} element that it 'sees' has no implicit <code>role</code>, such as with {{tag|p|content=Content}} for instance, and there is no <code>aria-label</code> given... So I suggest we give it these values, especially since:
{{tq2|<nowiki>If presentation or none is applied to a <table> element, the descendant <caption>, <thead>, <tbody>, <tfoot>, <tr>, <th>, and <td> elements inherit the role and are thus not exposed to assistive technologies.</nowiki>'''<nowiki>But, elements inside of the <th> and <td> elements, including nested tables, are exposed to assistive technologies.</nowiki>'''}} — taken from [https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Reference/Roles/presentation_role].
I interpret this as meaning that the {{tag|img|o}} element inside the first {{tag|td|o}} element will be exposed, and it is simply an image/icon with no benefit to the screen reader or the visually impaired... so give the image {{tag|td|o}} element with class <code>mbox-image</code> the HTML attribute: <code>aria-hidden="true"</code>; so that it is '''completely''' hidden from the accessibility technology.

The next {{tag|td|o}} nests our <code>mbox-text</code> class with the actual stuff we want to expose. But we want to give it meaning too. The role should be: <code>role="note"</code> as it's a note semantically speaking and does not fit any other ARIA <code>role</code>, and the child elements of that will all be exposed to the API as whatever has placed in the text parameter anyway (as confirmed in the quote above). Finally I suggest giving it an <code>aria-label="Notice"</code> if {{para|type|notice}} or <code>style</code> or <code>content</code>, and possibly <code>aria-label="Warning"</code> if <code>delete</code> or <code>speedy</code>. So it'll read out with a screen reader for example as: {{kbd|Note. Notice. Content...}}

Option 2... the parent element may actually be what we need to expose because it's nesting the whole dang thing? I don't think it matters since the parent elements of the text element are hidden from the API but another solution possibility could be setting the entire {{tag|table|o}}'s role to <code>role="note"</code> and giving it an <code>aria-label="Notice"</code>, and then still hiding the image, and then leaving the text element alone, however I'm unsure if the note role is inherited by child elements like the none/presentation role is.

[[User:Waddie96|waddie96]] ★ ([[User talk:Waddie96|talk]]) 00:19, 29 August 2025 (UTC)
:How about we wait to suss out how we want to deal with any accessibility questions here after I've got everything in divs, as in the section just above. Anyway, I think the last time I looked at this, the most similar was role=note for what message boxes represent. I am pretty sure I am not a fan of adding labels here, which should be when the content needs naming, and this does not. [[User:Izno|Izno]] ([[User talk:Izno|talk]]) 03:24, 29 August 2025 (UTC)
:(In fact, the div version already removes the presentation role.) [[User:Izno|Izno]] ([[User talk:Izno|talk]]) 05:18, 29 August 2025 (UTC)
::Cool. Please do ping me in discussions when this is revived. I've read extensively for many hours for something else and I'm quite well versed in it now. Yes, <code>role="note"</code> is the most appropriate role. Also, after testing it in the enwiki context using a few different screenreaders I tend to agree with you that an <code>aria-label</code> in this case is unnecessary "fluff" to the accessibility tree for the mbox, since as you stated the text describes itself. 👍 [[User:Waddie96|waddie96]] ★ ([[User talk:Waddie96|talk]]) 14:56, 29 August 2025 (UTC)
::Awesome. Can it give the image the HTML attr <code>aria-hidden="true"</code> too? Please 🙏 [[User:Waddie96|waddie96]] ★ ([[User talk:Waddie96|talk]]) 14:59, 29 August 2025 (UTC)
{{archive bottom}}
::Wow, thought I'd summarise:
::#Change the ARIA role given to the parent {{tag|table|o}} element to {{code|role{{=}}none|lang=html}}. Synonymous to <code>presentation</code>, i.e. identical function of removing all semantic meaning of table element and its direct children, but the latter is soon-to-be deprecated HTML.

::#Hide the images please: wrap the default image, and especially the custom left and right images (since the default at least has a null {{para|alt}}) with <syntaxhighlight inline lang=wikitext>...</syntaxhighlight>.
::Sorry, I'd edit the module in sandbox and give diffs but I have no idea how to code in Lua. Thank you! [[User:Waddie96|waddie96]] ★ ([[User talk:Waddie96|talk]]) 19:14, 2 September 2025 (UTC)
:::I think Izno suggested waiting until the div conversion was done, and then looking to see if anything like this is needed? — Martin ([[User:MSGJ|MSGJ]] · [[User talk:MSGJ|talk]]) 14:33, 4 September 2025 (UTC)
::::Yes apologies. I see that now. [[User:Waddie96|waddie96]] ★ ([[User talk:Waddie96|talk]]) 23:44, 4 September 2025 (UTC)
==Change background color for .fmbox-warning==
{{edit template-protected|Module:Message box/fmbox.css|answered=no}}
Current background color doesn't meet WCAG AA contrast requirements with links color used in Vector-2022, Timeless and Minerva, so I request to change it from <code>#ffdbdb</code> to <code>#ffe6de</code>.

More specifically, edit the 14th line so that
<pre>
background-color: #ffdbdb; /* Pink */
</pre>
becomes
<pre>
background-color: #ffe6de; /* Pink */
</pre>. [[User:Sapphaline|Sapphaline]] ([[User talk:Sapphaline|talk]]) 18:02, 10 September 2025 (UTC)
:Hmm why not change it to <code>var(--background-color-destructive-subtle, #ffe6de);</code>? [[User:Waddie96|waddie96]] ★ ([[User talk:Waddie96|talk]]) 18:05, 11 September 2025 (UTC)
::Then it'll be dynamic, adaptive for CSS themes, and change in dark mode [[User:Waddie96|waddie96]] ★ ([[User talk:Waddie96|talk]]) 18:07, 11 September 2025 (UTC)

Module talk:Message box - Revision history

CosmicAvelyn: 1 revision imported

Wikipedia>Waddie96: /* Change background color for .fmbox-warning */ Reply